URL with ~ (or others) not supported correctly in media management

[jcdubacq]

Due to the use of sprintf on the URL (line 269 of inc/core/class.dc.media.php) the media management works incorrectly (no thumbnail shown, various other strange things) when the URL of the blog contains a % sign (which happens if you have a ~ in your URL) because ~ becomes %7E and this is interpreted by sprintf.

Simple patch:

--- inc/core/class.dc.media.php (révision 2743)
+++ inc/core/class.dc.media.php (copie de travail)
@@ -267,7 +267,7 @@
                        $f->media_thumb = array();
                        $p = path::info($f->relname);
                        $thumb = sprintf($this->thumb_tp,$this->root.'/'.$p['dir
name'],$p['base'],'%s');
-                       $thumb_url = sprintf($this->thumb_tp,$this->root_url.$p[
'dirname'],$p['base'],'%s');
+                       $thumb_url = sprintf($this->thumb_tp,preg_replace('#%#',
'%%',$this->root_url).$p['dirname'],$p['base'],'%s');
                        
                        # Cleaner URLs
                        $thumb_url = preg_replace('#\./#','/',$thumb_url);

[xave]

I bet a broader solution is to be studied, where a good escaping is done in every case. I think we already have the right fuctions to do so.

[jcdubacq]

Possibly. This one was quite annoying to me. See also #592 (same type of error inside clearbricks).

[xave]

See #592

[xave]

further tests show it is not a duplicate

[xave]

I see no need to use "%7E" rather than "~" in public_path. Anyway...

[xave]

(In [2830]) URL protection Closes #720.