Issue with Dotclear 2.6.2 and sqlite -> user management

[le_top]

Hi User management is not possible with my dotclear + sqlite installation. When clicking on Users (Utilisateurs in French) which links to /admin/users.php, I get the following error message: ambiguous column name: user_id (1)

[peterk]

This bug is also present in version 2.6.3. It's cause: default sorting column set to 'user_id' in admin/users.php on line 54 (in version 2.6.3):

$sortby = !empty($_GET['sortby']) ?	$_GET['sortby'] : 'user_id';

Fix: change the above to

$sortby = !empty($_GET['sortby']) ?	$_GET['sortby'] : 'U.user_id';

The error shows up in inc/core/class.dc.core.php, around lines 503...513 (in version 2.6.3), which generates this query:

SELECT U.user_id,user_super,user_status,user_pwd,user_change_pwd,user_name,user_firstname,user_displayname,user_email,user_url,user_desc, user_lang,user_tz, user_post_status,user_options, count(P.post_id) AS nb_post FROM dc_user U LEFT JOIN dc_post P ON U.user_id = P.user_id WHERE NULL IS NULL GROUP BY U.user_id,user_super,user_status,user_pwd,user_change_pwd,user_name,user_firstname,user_displayname,user_email,user_url,user_desc, user_lang,user_tz,user_post_status,user_options  ORDER BY user_id asc  LIMIT 30 OFFSET 0;

Dotclear experts: I don't know why/whether this doesn't fail with other DB systems - please investigate.

This is a blocker for Automated testing of Dotclear -  http://forum.dotclear.org/viewtopic.php?pid=328372.

[franck]

The fix should not be on line 54, as proposed, because of test done on line 67.

The U prefix should also be not known by this part of code and we need to find a better (and more elegant) way to fox that.

[franck]

is this bug still relevant?

[peterk]

Hi Franck,

Thanks. This has been fixed.

Would you close this ticket, please.