Dotclear

Ticket #1761 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

Form in form makes media page html invalid

Reported by: nikrou Owned by: team
Priority: normal Milestone: 2.6
Component: module:mediamanager Version: 2.5
Severity: normal Keywords:
Cc:

Description

The media page is invalid because we put form in form. To see the problem try to attach a media to a post entry. The result page admin/media.php?post_id=N is invalid.

I propose to change the form (to attach a media) by a link (tag a). In javascript we convert the link target to a post request so that admin/post_media.php behaves like today. Just have to add a test in admin/post_media.php to return an url if its an ajax request.

The only issue is to attach a media to a script when user doesn't have javascript enable. We cannot convert the normal link to a post request.

Change History

comment:1 Changed 12 years ago by franck

Is the invalidity of this page really a problem?

comment:2 Changed 12 years ago by Nicolas <nikrou77@…>

  • Status changed from new to closed
  • Resolution set to fixed

(In [89c91e538879]) Fix invalid html for media page (in attachment context) because of nested form. Closes #1761

comment:3 Changed 12 years ago by franck

  • Milestone changed from A definir to 2.6
Note: See TracTickets for help on using tickets.

Sites map