Changeset 3980:df625feec28c for plugins/themeEditor/_admin.php

Timestamp:

06/24/19 14:29:57 (6 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

default

Message:

Switching from inline JS variables to JSON script, theme editor plugin

File:

• plugins/themeEditor/_admin.php (modified) (2 diffs)

plugins/themeEditor/_admin.php

@@ -70 +70 @@
             form::combo('colorsyntax_theme', $themes_combo,
                 [
-                    'default'    => $core->auth->user_prefs->interface->colorsyntax_theme,
-                    'extra_html' => 'onchange="selectTheme()"']) .
+                    'default' => $core->auth->user_prefs->interface->colorsyntax_theme
+                ]) .
                 '</p>';
         } else {
@@ -97 +97 @@
 }</textarea>';
         echo
-            '<script>
-            var input = document.getElementById("colorsyntax_theme");
-            var theme = input.options[input.selectedIndex].textContent;
-            var editor = CodeMirror.fromTextArea(document.getElementById("codemirror"), {
-                mode: "javascript",
-                tabMode: "indent",
-                lineWrapping: 1,
-                lineNumbers: 1,
-                matchBrackets: 1,
-                autoCloseBrackets: 1,
-                theme: "' . ($core->auth->user_prefs->interface->colorsyntax_theme != '' ? $core->auth->user_prefs->interface->colorsyntax_theme : 'default') . '"
-            });
-            function selectTheme() {
-                var input = document.getElementById("colorsyntax_theme");
-                var theme = input.options[input.selectedIndex].value;
-                if (theme == "") theme = "default";
-                editor.setOption("theme", theme);
-                editor.refresh();
-            }
-        </script>';
+        dcPage::jsJson('theme_editor_current', ['theme' => $core->auth->user_prefs->interface->colorsyntax_theme != '' ? $core->auth->user_prefs->interface->colorsyntax_theme : 'default']) .
+        dcPage::jsLoad(dcPage::getPF('themeEditor/js/theme.js'));
         echo '</div>';
         echo '</div>';