Dotclear


Ignore:
Timestamp:
02/18/18 18:16:29 (8 years ago)
Author:
franck <carnet.franck.paul@…>
Branch:
default
Message:

use strict and no more linter warnings/errors as far as possible, switch from inline js to separate loaded file

File:
1 edited

Legend:

Unmodified
Added
Removed

  • plugins/pages/list.php

    r3421 r3709  
    1010# 
    1111# -- END LICENSE BLOCK ----------------------------------------- 
    12 if (!defined('DC_CONTEXT_ADMIN')) { return; } 
     12if (!defined('DC_CONTEXT_ADMIN')) {return;} 
    1313dcPage::check('pages,contentadmin'); 
    1414 
    … …  
    1616-------------------------------------------------------- */ 
    1717$params = array( 
    18      'post_type' => 'page' 
     18    'post_type' => 'page' 
    1919); 
    2020 
    21 $page = !empty($_GET['page']) ? max(1,(integer) $_GET['page']) : 1; 
    22 $nb_per_page =  30; 
     21$page        = !empty($_GET['page']) ? max(1, (integer) $_GET['page']) : 1; 
     22$nb_per_page = 30; 
    2323 
    2424if (!empty($_GET['nb']) && (integer) $_GET['nb'] > 0) { 
    25      $nb_per_page = (integer) $_GET['nb']; 
     25    $nb_per_page = (integer) $_GET['nb']; 
    2626} 
    2727 
    28 $params['limit'] = array((($page-1)*$nb_per_page),$nb_per_page); 
     28$params['limit']      = array((($page - 1) * $nb_per_page), $nb_per_page); 
    2929$params['no_content'] = true; 
    30 $params['order'] = 'post_position ASC, post_title ASC'; 
     30$params['order']      = 'post_position ASC, post_title ASC'; 
    3131 
    3232try { 
    33      $pages = $core->blog->getPosts($params); 
    34      $counter = $core->blog->getPosts($params,true); 
    35      $post_list = new adminPagesList($core,$pages,$counter->f(0)); 
     33    $pages    = $core->blog->getPosts($params); 
     34    $counter   = $core->blog->getPosts($params, true); 
     35    $post_list = new adminPagesList($core, $pages, $counter->f(0)); 
    3636} catch (Exception $e) { 
    37      $core->error->add($e->getMessage()); 
     37    $core->error->add($e->getMessage()); 
    3838} 
    3939 
    4040# Actions combo box 
    4141 
    42 $pages_actions_page = new dcPagesActionsPage($core,'plugin.php',array('p'=>'pages')); 
     42$pages_actions_page = new dcPagesActionsPage($core, 'plugin.php', array('p' => 'pages')); 
    4343 
    4444if (!$pages_actions_page->process()) { 
    4545 
    46  
    4746# --BEHAVIOR-- adminPagesActionsCombo 
    48 $core->callBehavior('adminPagesActionsCombo',array(&$combo_action)); 
     47    $core->callBehavior('adminPagesActionsCombo', array(&$combo_action)); 
    4948 
    5049/* Display 
    5150-------------------------------------------------------- */ 
    52 ?> 
     51    ?> 
    5352<html> 
    5453<head> 
    5554  <title><?php echo __('Pages'); ?></title> 
    5655  <?php 
    57      echo 
    58           dcPage::jsLoad('js/jquery/jquery-ui.custom.js'). 
    59           dcPage::jsLoad('js/jquery/jquery.ui.touch-punch.js'). 
    60           dcPage::jsLoad(dcPage::getPF('pages/list.js')). 
    61           '<script type="text/javascript">'."\n". 
    62           dcPage::jsVar('dotclear.msg.confirm_delete_posts',__("Are you sure you want to delete selected pages?")). 
    63           '</script>'; 
     56echo 
     57    dcPage::jsLoad('js/jquery/jquery-ui.custom.js') . 
     58    dcPage::jsLoad('js/jquery/jquery.ui.touch-punch.js') . 
     59    dcPage::jsLoad(dcPage::getPF('pages/js/list.js')) . 
     60    '<script type="text/javascript">' . "\n" . 
     61    dcPage::jsVar('dotclear.msg.confirm_delete_posts', __("Are you sure you want to delete selected pages?")) . 
     62        '</script>'; 
    6463 
    65   ?> 
     64    ?> 
    6665</head> 
    6766 
    … …  
    6968<?php 
    7069echo dcPage::breadcrumb( 
    71      array( 
    72           html::escapeHTML($core->blog->name) => '', 
    73           __('Pages') => '' 
    74      )).dcPage::notices(); 
     70        array( 
     71            html::escapeHTML($core->blog->name) => '', 
     72            __('Pages')                        => '' 
     73        )) . dcPage::notices(); 
    7574 
    76 if (!empty($_GET['upd'])) { 
    77      dcPage::success(__('Selected pages have been successfully updated.')); 
    78 } elseif (!empty($_GET['del'])) { 
    79      dcPage::success(__('Selected pages have been successfully deleted.')); 
    80 } elseif (!empty($_GET['reo'])) { 
    81      dcPage::success(__('Selected pages have been successfully reordered.')); 
    82 } 
    83 echo 
    84 '<p class="top-add"><a class="button add" href="'.$p_url.'&amp;act=page">'.__('New page').'</a></p>'; 
     75    if (!empty($_GET['upd'])) { 
     76        dcPage::success(__('Selected pages have been successfully updated.')); 
     77    } elseif (!empty($_GET['del'])) { 
     78        dcPage::success(__('Selected pages have been successfully deleted.')); 
     79    } elseif (!empty($_GET['reo'])) { 
     80        dcPage::success(__('Selected pages have been successfully reordered.')); 
     81    } 
     82    echo 
     83    '<p class="top-add"><a class="button add" href="' . $p_url . '&amp;act=page">' . __('New page') . '</a></p>'; 
    8584 
    86 if (!$core->error->flag()) 
    87 { 
    88      # Show pages 
    89      $post_list->display($page,$nb_per_page, 
    90      '<form action="'.$core->adminurl->get('admin.plugin').'" method="post" id="form-entries">'. 
     85    if (!$core->error->flag()) { 
     86        # Show pages 
     87        $post_list->display($page, $nb_per_page, 
     88            '<form action="' . $core->adminurl->get('admin.plugin') . '" method="post" id="form-entries">' . 
    9189 
    92      '%s'. 
     90            '%s' . 
    9391 
    94      '<div class="two-cols">'. 
    95      '<p class="col checkboxes-helpers"></p>'. 
     92            '<div class="two-cols">' . 
     93            '<p class="col checkboxes-helpers"></p>' . 
    9694 
    97      '<p class="col right"><label for="action" class="classic">'.__('Selected pages action:').'</label> '. 
    98      form::combo('action',$pages_actions_page->getCombo()). 
    99      '<input id="do-action" type="submit" value="'.__('ok').'" />'. 
    100      form::hidden(array('post_type'),'page'). 
    101      form::hidden(array('p'),'pages'). 
    102      form::hidden(array('act'),'list'). 
    103      $core->formNonce(). 
    104      '</p></div>'. 
    105      '<p class="clear form-note hidden-if-js">'. 
    106      __('To rearrange pages order, change number at the begining of the line, then click on “Save pages order” button.').'</p>'. 
    107      '<p class="clear form-note hidden-if-no-js">'. 
    108      __('To rearrange pages order, move items by drag and drop, then click on “Save pages order” button.').'</p>'. 
    109      '<p><input type="submit" value="'.__('Save pages order').'" name="reorder" class="clear" /></p>'. 
    110      '</form>'); 
    111 } 
    112 dcPage::helpBlock('pages'); 
    113 ?> 
     95            '<p class="col right"><label for="action" class="classic">' . __('Selected pages action:') . '</label> ' . 
     96            form::combo('action', $pages_actions_page->getCombo()) . 
     97            '<input id="do-action" type="submit" value="' . __('ok') . '" />' . 
     98            form::hidden(array('post_type'), 'page') . 
     99            form::hidden(array('p'), 'pages') . 
     100            form::hidden(array('act'), 'list') . 
     101            $core->formNonce() . 
     102            '</p></div>' . 
     103            '<p class="clear form-note hidden-if-js">' . 
     104            __('To rearrange pages order, change number at the begining of the line, then click on “Save pages order” button.') . '</p>' . 
     105            '<p class="clear form-note hidden-if-no-js">' . 
     106            __('To rearrange pages order, move items by drag and drop, then click on “Save pages order” button.') . '</p>' . 
     107            '<p><input type="submit" value="' . __('Save pages order') . '" name="reorder" class="clear" /></p>' . 
     108            '</form>'); 
     109    } 
     110    dcPage::helpBlock('pages'); 
     111    ?> 
    114112</body> 
    115113</html> 
Note: See TracChangeset for help on using the changeset viewer.

Sites map