Changeset 1041:ffd8fd14003c for admin

Timestamp:

11/25/12 22:38:00 (13 years ago)

Author:

JcDenis

Branch:

default

Message:

Enhance mass comments actions by reducing SQL queries, addresses #943

File:

• admin/comments_actions.php (modified) (3 diffs)

admin/comments_actions.php

@@ -52 +52 @@
      $co = $core->blog->getComments($params);
      
+     $co_ids = array();
+     while ($co->fetch())     {
+          $co_ids[] = $co->comment_id;
+     }
+     
      # --BEHAVIOR-- adminCommentsActions
      $core->callBehavior('adminCommentsActions',$core,$co,$action,$redir);
@@ -64 +69 @@
           }
           
-          while ($co->fetch())
-          {
-               try {
-                    $core->blog->updCommentStatus($co->comment_id,$status);
-               } catch (Exception $e) {
-                    $core->error->add($e->getMessage());
-               }
+          try {
+               $core->blog->updCommentsStatus($co_ids,$status);
+          } catch (Exception $e) {
+               $core->error->add($e->getMessage());
           }
           
@@ -79 +81 @@
      elseif ($action == 'delete')
      {
-          while ($co->fetch())
-          {
-               try {
+          try {
+               // Backward compatibility
+               foreach($co_ids as $comment_id)
+               {
                     # --BEHAVIOR-- adminBeforeCommentDelete
-                    $core->callBehavior('adminBeforeCommentDelete',$co->comment_id);                
-                    
-                    $core->blog->delComment($co->comment_id);
-               } catch (Exception $e) {
-                    $core->error->add($e->getMessage());
+                    $core->callBehavior('adminBeforeCommentDelete',$comment_id);                    
                }
+               
+               # --BEHAVIOR-- adminBeforeCommentsDelete
+               $core->callBehavior('adminBeforeCommentsDelete',$co_ids);
+               
+               $core->blog->delComments($co_ids);
+          } catch (Exception $e) {
+               $core->error->add($e->getMessage());
           }