Changeset 1116:fc027f45784a for inc/load_plugin_file.php

Timestamp:

03/14/13 09:46:33 (12 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

2.5

Message:

Better way to prevent XSS vulnerabilities in swfupload.swf and other unwanted param in URL (thank's Julien Wajsberg)

File:

• inc/load_plugin_file.php (modified) (1 diff)

inc/load_plugin_file.php

@@ -47 +47 @@
 }
 
-// Prevents XSS vulnerabilities in swfupload.swf
-if (((isset($_GET['buttonText']) && strpos($_GET['buttonText'],'<') !== false) ||
-     (isset($_GET['movieName']) && strpos($_GET['movieName'],';') !== false)) &&
-     strpos($_GET['pf'],'swfupload.swf') !== false) {
-     {
-          header('Content-Type: text/plain');
-          http::head(403,'Forbidden');
-          exit;
-     }
+// Only $_GET['pf'] is allowed in URL
+if (count($_GET) > 1)
+{
+    header('Content-Type: text/plain');
+    http::head(403,'Forbidden');
+    exit;
 }