Changeset 795:eab85d2136f6 for admin

Timestamp:

02/08/12 21:00:24 (14 years ago)

Author:

Dsls <dsls@…>

Branch:

2.4

Message:

Advisory ID: HTB23074 - 1.3: Sanitize comments.php and posts.php filter parameters

Location:

admin

Files:

• comments.php (modified) (1 diff)
• posts.php (modified) (1 diff)

admin/comments.php

@@ -45 +45 @@
 /* Get comments
 -------------------------------------------------------- */
-$author = isset($_GET['author']) ? $_GET['author'] : '';
-$status = isset($_GET['status']) ?      $_GET['status'] : '';
-$type = !empty($_GET['type']) ?         $_GET['type'] : '';
-$sortby = !empty($_GET['sortby']) ?     $_GET['sortby'] : 'comment_dt';
-$order = !empty($_GET['order']) ?       $_GET['order'] : 'desc';
-$ip = !empty($_GET['ip']) ?             $_GET['ip'] : '';
+$author = isset($_GET['author']) ? html::escapeHTML($_GET['author']) : '';
+$status = isset($_GET['status']) ?      html::escapeHTML($_GET['status']) : '';
+$type = !empty($_GET['type']) ?         html::escapeHTML($_GET['type']) : '';
+$sortby = !empty($_GET['sortby']) ?     html::escapeHTML($_GET['sortby']) : 'comment_dt';
+$order = !empty($_GET['order']) ?       html::escapeHTML($_GET['order']) : 'desc';
+$ip = !empty($_GET['ip']) ?             html::escapeHTML($_GET['ip']) : '';
 
 $with_spam = $author || $status || $type || $sortby != 'comment_dt' || $order != 'desc' || $ip;

admin/posts.php

@@ -138 +138 @@
 /* Get posts
 -------------------------------------------------------- */
-$user_id = !empty($_GET['user_id']) ?   $_GET['user_id'] : '';
-$cat_id = !empty($_GET['cat_id']) ?     $_GET['cat_id'] : '';
-$status = isset($_GET['status']) ? $_GET['status'] : '';
-$selected = isset($_GET['selected']) ?  $_GET['selected'] : '';
-$month = !empty($_GET['month']) ?       $_GET['month'] : '';
-$lang = !empty($_GET['lang']) ?         $_GET['lang'] : '';
-$sortby = !empty($_GET['sortby']) ?     $_GET['sortby'] : 'post_dt';
-$order = !empty($_GET['order']) ?       $_GET['order'] : 'desc';
+$user_id = !empty($_GET['user_id']) ?   html::escapeHTML($_GET['user_id']) : '';
+$cat_id = !empty($_GET['cat_id']) ?     html::escapeHTML($_GET['cat_id']) : '';
+$status = isset($_GET['status']) ? html::escapeHTML($_GET['status']) : '';
+$selected = isset($_GET['selected']) ?  html::escapeHTML($_GET['selected']) : '';
+$month = !empty($_GET['month']) ?       html::escapeHTML($_GET['month']) : '';
+$lang = !empty($_GET['lang']) ?         html::escapeHTML($_GET['lang']) : '';
+$sortby = !empty($_GET['sortby']) ?     html::escapeHTML($_GET['sortby']) : 'post_dt';
+$order = !empty($_GET['order']) ?       html::escapeHTML($_GET['order']) : 'desc';
 
 $show_filters = false;