Changeset 3447:b1afe8a19f26 for admin

Timestamp:

12/08/16 17:44:54 (9 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

default

Message:

Revert meta-editor.js buttons to a void links, fixes #2226 (addresses #1776)

Location:

admin

Files:

• js/meta-editor.js (modified) (5 diffs)
• style/default.css (modified) (4 diffs)
• style/scss/partials/_buttons.scss (modified) (3 diffs)

admin/js/meta-editor.js

@@ -81 +81 @@
                for (var i=0; i < meta.length; i++) {
                     li = $('<li>'+meta[i]+'</li>');
-                    a_remove = $('<button type="button" class="metaRemove meta-helper"><img src="images/trash.png" alt="remove" /></button>');
+                    a_remove = $('<a href="#" type="button" class="metaRemove meta-helper"><img src="images/trash.png" alt="remove" /></a>');
                     a_remove.get(0).caller = this;
                     a_remove.get(0).meta_id = meta[i];
@@ -109 +109 @@
                          var meta_id = $(this).text();
                          li = $('<li><a href="' + This.meta_url + $(this).attr('uri') + '">'+meta_id+'</a></li>');
-                         a_remove = $('<button type="button" class="metaRemove meta-helper"><img src="images/trash.png" alt="remove" /></button>');
+                         a_remove = $('<a href="#" type="button" class="metaRemove meta-helper"><img src="images/trash.png" alt="remove" /></a>');
                          a_remove.get(0).caller = This;
                          a_remove.get(0).meta_id = meta_id;
@@ -163 +163 @@
 
                     $(data).find('meta').each(function(i) {
-                         meta_link = $('<button type="button" class="metaItem meta-helper">' + $(this).text() + '</button>');
+                         meta_link = $('<a href="#" type="button" class="metaItem meta-helper">' + $(this).text() + '</a>');
                          meta_link.get(0).meta_id = $(this).text();
                          meta_link.click(function() {
@@ -178 +178 @@
 
                     if (list_type == 'more') {
-                         var a_more = $('<button type="button" class="metaGetMore meta-helper"></button>');
+                         var a_more = $('<a href="#" type="button" class="button metaGetMore meta-helper"></a>');
                          a_more.append(This.text_all + String.fromCharCode(160)+String.fromCharCode(187));
                          a_more.click(function() {
@@ -193 +193 @@
                          target.append(pa);
 
-                         var a = $('<button type="button" class="metaGetList meta-helper">' + This.text_choose + '</button>');
+                         var a = $('<a href="#" type="button" class="button metaGetList meta-helper">' + This.text_choose + '</a>');
                          a.click(function() {
                               $(this).parent().next().removeClass('hide');

admin/style/default.css

@@ -1362 +1362 @@
 #gototop,
 .metaGetList,
-.metaGetMore {
+.metaGetMore,
+a.checkbox-helper,
+a#gototop,
+a.metaGetList,
+a.metaGetMore {
   font-size: 0.825em;
   color: #333;
@@ -1374 +1378 @@
   #gototop:hover,
   .metaGetList:hover,
-  .metaGetMore:hover {
+  .metaGetMore:hover,
+  a.checkbox-helper:hover,
+  a#gototop:hover,
+  a.metaGetList:hover,
+  a.metaGetMore:hover {
     background: #a2cbe9;
     box-shadow: none;
@@ -1397 +1405 @@
 
 .metaRemove,
-.addMeta button:not(.metaGetMore) {
+.addMeta button:not(.metaGetMore),
+.addMeta a:not(.metaGetMore) {
   border: none;
   border-radius: 0;
@@ -1403 +1412 @@
   background: none; }
 
-.addMeta button:not(.metaGetMore) {
+.addMeta button:not(.metaGetMore),
+.addMeta a:not(.metaGetMore) {
   text-shadow: initial;
   box-shadow: initial;
   margin-bottom: 2px; }
-  .addMeta button:not(.metaGetMore):hover, .addMeta button:not(.metaGetMore):focus {
+  .addMeta button:not(.metaGetMore):hover, .addMeta button:not(.metaGetMore):focus,
+  .addMeta a:not(.metaGetMore):hover,
+  .addMeta a:not(.metaGetMore):focus {
     background: #fc0; }
 

admin/style/scss/partials/_buttons.scss

@@ -227 +227 @@
 #gototop,
 .metaGetList,
-.metaGetMore {
+.metaGetMore,
+a.checkbox-helper,
+a#gototop,
+a.metaGetList,
+a.metaGetMore {
      font-size: 0.825em;
      color: #333;
@@ -263 +267 @@
 
 .metaRemove,
-.addMeta button:not(.metaGetMore) {
+.addMeta button:not(.metaGetMore),
+.addMeta a:not(.metaGetMore) {
      border: none;
      border-radius: 0;
@@ -270 +275 @@
 }
 
-.addMeta button:not(.metaGetMore) {
+.addMeta button:not(.metaGetMore),
+.addMeta a:not(.metaGetMore) {
      text-shadow: initial;
      box-shadow: initial;