Changeset 3182:adf3c934173f

Timestamp:

02/22/16 16:15:18 (9 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

default

Message:

Disable submit button unless at least one item selected whenever is possible, closes #1600

Files:

• admin/comments.php (modified) (1 diff)
• admin/js/_comments.js (modified) (1 diff)
• admin/js/_media.js (modified) (1 diff)
• admin/js/_posts_actions.js (modified) (1 diff)
• admin/js/_posts_list.js (modified) (1 diff)
• admin/js/_users.js (modified) (1 diff)
• admin/js/_users_actions.js (modified) (1 diff)
• admin/js/common.js (modified) (5 diffs)
• admin/posts.php (modified) (1 diff)
• admin/search.php (modified) (2 diffs)
• admin/users.php (modified) (1 diff)
• admin/users_actions.php (modified) (1 diff)
• plugins/blogroll/blogroll.js (modified) (1 diff)
• plugins/blogroll/index.php (modified) (1 diff)
• plugins/maintenance/js/settings.js (modified) (2 diffs)
• plugins/pages/list.js (modified) (2 diffs)
• plugins/pages/list.php (modified) (1 diff)
• plugins/simpleMenu/index.php (modified) (1 diff)
• plugins/simpleMenu/simplemenu.js (modified) (1 diff)
• plugins/tags/tag_posts.php (modified) (1 diff)

admin/comments.php

@@ -267 +267 @@
      form::combo('action',$comments_actions_page->getCombo(),$default,'','','','title="'.__('Actions').'"').
      $core->formNonce().
-     '<input type="submit" value="'.__('ok').'" /></p>'.
+     '<input id="do-action" type="submit" value="'.__('ok').'" /></p>'.
      form::hidden(array('type'),$type).
      form::hidden(array('sortby'),$sortby).

admin/js/_comments.js

@@ -60 +60 @@
      });
      $('.checkboxes-helpers').each(function() {
-          dotclear.checkboxesHelpers(this);
+          dotclear.checkboxesHelpers(this,undefined,'#form-comments td input[type=checkbox]','#form-comments #do-action');
      });
      $('#form-comments td input[type=checkbox]').enableShiftClick();
      dotclear.commentsActionsHelper();
+     dotclear.condSubmit('#form-comments td input[type=checkbox]','#form-comments #do-action');
      $('form input[type=submit][name=delete_all_spam]').click(function(){
           return window.confirm(dotclear.msg.confirm_spam_delete);

admin/js/_media.js

@@ -135 +135 @@
 
      $('.checkboxes-helpers').each(function() {
-          dotclear.checkboxesHelpers(this);
+          dotclear.checkboxesHelpers(this,undefined,'#form-medias input[type="checkbox"]','#form-medias #delete_medias');
      });
+     dotclear.condSubmit('#form-medias input[type="checkbox"]','#form-medias #delete_medias');
 
      $('#form-medias #delete_medias').click(function(e) {

admin/js/_posts_actions.js

@@ -13 +13 @@
           legend_click: true
      });
+     dotclear.condSubmit('table.posts-list td input[type=checkbox]','input[type=submit]');
 });

admin/js/_posts_list.js

@@ -60 +60 @@
      });
      $('.checkboxes-helpers').each(function() {
-          dotclear.checkboxesHelpers(this);
+          dotclear.checkboxesHelpers(this,undefined,'#form-entries td input[type=checkbox]','#form-entries #do-action');
      });
      $('#form-entries td input[type=checkbox]').enableShiftClick();
+     dotclear.condSubmit('#form-entries td input[type=checkbox]','#form-entries #do-action');
      dotclear.postsActionsHelper();
 });

admin/js/_users.js

@@ -1 +1 @@
 $(function() {
      $('.checkboxes-helpers').each(function() {
-          dotclear.checkboxesHelpers(this);
+          dotclear.checkboxesHelpers(this,undefined,'#form-users input[type="checkbox"]','#form-users #do-action');
      });
+     dotclear.condSubmit('#form-users input[type="checkbox"]','#form-users #do-action');
      $('#form-users').submit(function() {
           var action = $(this).find('select[name="action"]').val();

admin/js/_users_actions.js

@@ -93 +93 @@
 $(function() {
      $('.checkboxes-helpers').each(function() {
-          dotclear.checkboxesHelpers(this);
+          dotclear.checkboxesHelpers(this,undefined,'#form-blogs input[type="checkbox"]','#form-blogs #do-action');
      });
+     dotclear.condSubmit('#form-blogs input[type="checkbox"]','#form-blogs #do-action');
      $('#permissions-form').updatePermissionsForm();
 });

admin/js/common.js

@@ -311 +311 @@
      msg: {},
 
+     condSubmit: function(chkboxes,target) {
+          var checkboxes = $(chkboxes),
+              submitButt = $(target);
+
+          if (checkboxes === undefined || submitButt === undefined) {
+               return;
+          }
+
+          // Set initial state
+         submitButt.attr("disabled", !checkboxes.is(":checked"));
+         if (!checkboxes.is(":checked")) {
+          submitButt.addClass('disabled');
+         } else {
+          submitButt.removeClass('disabled');
+         }
+
+          checkboxes.click(function() {
+               // Update target state
+              submitButt.attr("disabled", !checkboxes.is(":checked"));
+              if (!checkboxes.is(":checked")) {
+               submitButt.addClass('disabled');
+              } else {
+               submitButt.removeClass('disabled');
+              }
+          });
+     },
+
      hideLockable: function() {
           $('div.lockable').each(function() {
@@ -342 +369 @@
      },
 
-     checkboxesHelpers: function(e, target) {
+     checkboxesHelpers: function(e, target, c, s) {
           $(e).append(document.createTextNode(dotclear.msg.to_select));
           $(e).append(document.createTextNode(' '));
@@ -352 +379 @@
                     $(e).parents('form').find('input[type="checkbox"]').check();
                }
-
+               if (c !== undefined && s !== undefined) {
+                    dotclear.condSubmit(c,s);
+               }
                return false;
           }).appendTo($(e));
@@ -363 +392 @@
                     $(e).parents('form').find('input[type="checkbox"]').unCheck();
                }
-
+               if (c !== undefined && s !== undefined) {
+                    dotclear.condSubmit(c,s);
+               }
                return false;
           }).appendTo($(e));
@@ -374 +405 @@
                     $(e).parents('form').find('input[type="checkbox"]').toggleCheck();
                }
-
+               if (c !== undefined && s !== undefined) {
+                    dotclear.condSubmit(c,s);
+               }
                return false;
           }).appendTo($(e));

admin/posts.php

@@ -389 +389 @@
      '<p class="col right"><label for="action" class="classic">'.__('Selected entries action:').'</label> '.
      form::combo('action',$posts_actions_page->getCombo()).
-     '<input type="submit" value="'.__('ok').'" /></p>'.
+     '<input id="do-action" type="submit" value="'.__('ok').'" disabled /></p>'.
      form::hidden(array('user_id'),$user_id).
      form::hidden(array('cat_id'),$cat_id).

admin/search.php

@@ -127 +127 @@
           '<p class="col right"><label for="action1" class="classic">'.__('Selected entries action:').'</label> '.
           form::combo(array('action','action1'),$posts_actions_page->getCombo()).
-          '<input type="submit" value="'.__('ok').'" /></p>'.
+          '<input id="do-action" type="submit" value="'.__('ok').'" /></p>'.
           $core->formNonce().
           $posts_actions_page->getHiddenFields().
@@ -155 +155 @@
           '<p class="col right"><label for="action2" class="classic">'.__('Selected comments action:').'</label> '.
           form::combo(array('action','action2'),$comments_actions_page->getCombo()).
-          '<input type="submit" value="'.__('ok').'" /></p>'.
+          '<input id="do-action" type="submit" value="'.__('ok').'" /></p>'.
           $core->formNonce().
           $comments_actions_page->getHiddenFields().

admin/users.php

@@ -169 +169 @@
      form::combo('action',$combo_action).
      '</label> '.
-     '<input type="submit" value="'.__('ok').'" />'.
+     '<input id="do-action" type="submit" value="'.__('ok').'" />'.
      form::hidden(array('q'),html::escapeHTML($q)).
      form::hidden(array('sortby'),$sortby).

admin/users_actions.php

@@ -244 +244 @@
           '</table></div>'.
           '<p class="checkboxes-helpers"></p>'.
-          '<p><input type="submit" value="'.__('Set permissions').'" />'.
+          '<p><input id="do-action" type="submit" value="'.__('Set permissions').'" />'.
           $hidden_fields.
           form::hidden(array('action'),'perms').

plugins/blogroll/blogroll.js

@@ -16 +16 @@
      $("#links-list tr td input.position").hide();
      $("#links-list tr td.handle").addClass('handler');
+     dotclear.condSubmit('#links-form td input[type="checkbox"]','#links-form #remove-action');
 });

plugins/blogroll/index.php

@@ -252 +252 @@
 ?>
 <input type="submit" name="saveorder" value="<?php echo __('Save order'); ?>" /></p>
-<p class="col right"><input type="submit" class="delete" name="removeaction"
+<p class="col right"><input id="remove-action" type="submit" class="delete" name="removeaction"
       value="<?php echo __('Delete selected links'); ?>"
       onclick="return window.confirm('

plugins/maintenance/js/settings.js

@@ -1 +1 @@
 $(function(){
-$('.recall-for-all').attr('disabled','disabled');
+     $('.recall-for-all').attr('disabled','disabled');
      $('#settings_recall_all').change(function(){
           if($(this).attr('selected')!='selected'){
@@ -13 +13 @@
           }
      });
+     dotclear.condSubmit('#part-maintenance input[type="radio"]','#part-maintenance input[type="submit"]');
+     dotclear.condSubmit('#part-backup input[type="radio"]','#part-backup input[type="submit"]');
+     dotclear.condSubmit('#part-dev input[type="radio"]','#part-dev input[type="submit"]');
 });

plugins/pages/list.js

@@ -1 +1 @@
 dotclear.viewPostContent = function(line,action) {
      var action = action || 'toggle';
+     if ($(line).attr('id') == undefined) { return; }
+
      var postId = $(line).attr('id').substr(1);
      var tr = document.getElementById('pe'+postId);
@@ -59 +61 @@
           p = $('<p></p>');
           $(this).prepend(p);
-          dotclear.checkboxesHelpers(p);
+          dotclear.checkboxesHelpers(p,undefined,'#pageslist td input[type=checkbox]','#form-entries #do-action');
      });
      $('#pageslist td input[type=checkbox]').enableShiftClick();
+     dotclear.condSubmit('#pageslist td input[type=checkbox]','#form-entries #do-action');
 
      $("#pageslist tr.line td:not(.expander)").mousedown(function(){

plugins/pages/list.php

@@ -99 +99 @@
      '<p class="col right"><label for="action" class="classic">'.__('Selected pages action:').'</label> '.
      form::combo('action',$pages_actions_page->getCombo()).
-     '<input type="submit" value="'.__('ok').'" />'.
+     '<input id="do-action" type="submit" value="'.__('ok').'" />'.
      form::hidden(array('post_type'),'page').
      form::hidden(array('p'),'pages').

plugins/simpleMenu/index.php

@@ -550 +550 @@
           echo '<p class="col">'.form::hidden('im_order','').$core->formNonce();
           echo '<input type="submit" name="updateaction" value="'.__('Update menu').'" />'.'</p>';
-          echo '<p class="col right">'.'<input type="submit" class="delete" name="removeaction" '.
+          echo '<p class="col right">'.'<input id="remove-action" type="submit" class="delete" name="removeaction" '.
                     'value="'.__('Delete selected menu items').'" '.
                     'onclick="return window.confirm(\''.html::escapeJS(__('Are you sure you want to remove selected menu items?')).'\');" />'.

plugins/simpleMenu/simplemenu.js

@@ -16 +16 @@
      $("#menuitemslist tr td input.position").hide();
      $("#menuitemslist tr td.handle").addClass('handler');
+     dotclear.condSubmit('#menuitems tr td input[type="checkbox"]','#menuitems #remove-action');
 });

plugins/tags/tag_posts.php

@@ -138 +138 @@
      '<p class="col right"><label for="action" class="classic">'.__('Selected entries action:').'</label> '.
      form::combo('action',$posts_actions_page->getCombo()).
-     '<input type="submit" value="'.__('OK').'" /></p>'.
+     '<input id="do-action" type="submit" value="'.__('OK').'" /></p>'.
      form::hidden('post_type','').
      form::hidden('p','tags').