Changeset 2527:52b330f07bd8 for admin/js/_post.js

Timestamp:

11/08/13 16:54:05 (12 years ago)

Author:

Nicolas <nikrou77@…>

Branch:

2.6

Message:

Fix a11y when expanding content in lists views (entries, comments, pages)
Closes #1848
Need refactoring and tests !

File:

• admin/js/_post.js (modified) (4 diffs)

admin/js/_post.js

@@ -1 +1 @@
 dotclear.commentExpander = function(line) {
-     var td = line.firstChild;
-
-     var img = document.createElement('img');
-     img.src = dotclear.img_plus_src;
-     img.alt = dotclear.img_plus_alt;
-     img.className = 'expand';
-     $(img).css('cursor','pointer');
-     img.line = line;
-     img.onclick = function() { dotclear.viewCommentContent(this,this.line); };
-
-     td.insertBefore(img,td.firstChild);
+     $('<a href="#"><img src="'+dotclear.img_plus_src+'" alt="'+dotclear.img_plus_alt+'"/></a>')
+          .click(function(e) {
+               dotclear.toggleArrow(this);
+               dotclear.viewCommentContent(line);
+               e.preventDefault();
+          })
+          .prependTo($(line).children().get(0)); // first td
 };
 
-dotclear.viewCommentContent = function(img,line) {
-     var commentId = line.id.substr(1);
-
+dotclear.toggleArrow = function(link,action) {
+     action = action || '';
+     var img = $(link).children().get(0);
+     if (action=='') {
+          if (img.alt==dotclear.img_plus_alt) {
+               action = 'open';
+          } else {
+               action = 'close';
+          }
+     }
+
+     if (action=='open') {
+          img.src = dotclear.img_minus_src;
+          img.alt = dotclear.img_minus_alt;
+     } else {
+          img.src = dotclear.img_plus_src;
+          img.alt = dotclear.img_plus_alt;
+     }
+
+     return action;
+}
+
+dotclear.viewCommentContent = function(line,action) {
+     var commentId = $(line).attr('id').substr(1);
      var tr = document.getElementById('ce'+commentId);
 
@@ -25 +42 @@
           td.className = 'expand';
           tr.appendChild(td);
-
-          img.src = dotclear.img_minus_src;
-          img.alt = dotclear.img_minus_alt;
 
           // Get comment content
@@ -60 +74 @@
           $(tr).toggle();
           $(line).toggleClass('expand');
-          img.src = dotclear.img_minus_src;
-          img.alt = dotclear.img_minus_alt;
      }
      else
@@ -67 +79 @@
           $(tr).toggle();
           $(line).toggleClass('expand');
-          img.src = dotclear.img_plus_src;
-          img.alt = dotclear.img_plus_alt;
      }
 };