Changeset 3880:e6d1f6d9d7df for plugins/dcCKEditor/js/ckeditor-plugins/dclink/plugin.js

Timestamp:

09/18/18 20:22:10 (7 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

default

Message:

Use let and const rather than var (ES2015/ES6), use template string where is more efficient

File:

• plugins/dcCKEditor/js/ckeditor-plugins/dclink/plugin.js (modified) (1 diff)

plugins/dcCKEditor/js/ckeditor-plugins/dclink/plugin.js

@@ +1 @@
+/*global CKEDITOR, dotclear, $ */
+'use strict';
+
 (function() {
-     CKEDITOR.plugins.add('dclink', {
-          icons: 'dclink',
-          init: function(editor) {
-               editor.addCommand('dcLinkCommand', {
-                    exec: function(editor) {
-                         if (editor.getSelection().getSelectedElement()!=null
-                             || editor.getSelection().getNative().toString().replace(/\s*/,'')!='') {
-                              $.toolbarPopup('popup_link.php?plugin_id=dcCKEditor');
-                         }
-                    }
-               });
+  CKEDITOR.plugins.add('dclink', {
+    icons: 'dclink',
+    init: function(editor) {
+      editor.addCommand('dcLinkCommand', {
+        exec: function(editor) {
+          if (editor.getSelection().getSelectedElement() != null ||
+            editor.getSelection().getNative().toString().replace(/\s*/, '') != '') {
+            $.toolbarPopup('popup_link.php?plugin_id=dcCKEditor');
+          }
+        }
+      });
 
-               editor.ui.addButton('dcLink', {
-                    label: dotclear.msg.link_title,
-                    command: 'dcLinkCommand',
-                    toolbar: 'insert'
-               });
+      editor.ui.addButton('dcLink', {
+        label: dotclear.msg.link_title,
+        command: 'dcLinkCommand',
+        toolbar: 'insert'
+      });
 
-               editor.on('doubleclick',function(e) {
-                    var element = CKEDITOR.plugins.link.getSelectedLink(editor) || e.data.element;
-                    if (!element.isReadOnly()) {
-                         if (element.is('a')
-                             && !element.hasClass('media-link') // link to original media @see js/popup_media.js
-                             && !element.hasClass('ref-post')) {    // link to an entry @see js/popup_posts.js
+      editor.on('doubleclick', function(e) {
+        const element = CKEDITOR.plugins.link.getSelectedLink(editor) || e.data.element;
+        if (!element.isReadOnly()) {
+          if (element.is('a') &&
+            !element.hasClass('media-link') && // link to original media @see js/popup_media.js
+            !element.hasClass('ref-post')) { // link to an entry @see js/popup_posts.js
 
-                              editor.getSelection().selectElement(element);
+            editor.getSelection().selectElement(element);
 
-                              var popup_url = 'popup_link.php?plugin_id=dcCKEditor';
-                              if (element.getAttribute('href')) {
-                                   popup_url += '&href='+element.getAttribute('href');
-                              }
-                              if (element.getAttribute('hreflang')) {
-                                   popup_url += '&hreflang='+element.getAttribute('hreflang');
-                              }
-                              if (element.getAttribute('title')) {
-                                   popup_url += '&title='+element.getAttribute('title');
-                              }
+            let popup_url = 'popup_link.php?plugin_id=dcCKEditor';
+            if (element.getAttribute('href')) {
+              popup_url += '&href=' + element.getAttribute('href');
+            }
+            if (element.getAttribute('hreflang')) {
+              popup_url += '&hreflang=' + element.getAttribute('hreflang');
+            }
+            if (element.getAttribute('title')) {
+              popup_url += '&title=' + element.getAttribute('title');
+            }
 
-                              $.toolbarPopup(popup_url);
-                              return false;
-                         }
-                    }
-               });
-          }
-     });
+            $.toolbarPopup(popup_url);
+            return false;
+          }
+        }
+      });
+    }
+  });
 })();