Changeset 3880:e6d1f6d9d7df for admin/js/confirm-close.js

Timestamp:

09/18/18 20:22:10 (7 years ago)

Author:

franck <carnet.franck.paul@…>

Branch:

default

Message:

Use let and const rather than var (ES2015/ES6), use template string where is more efficient

File:

• admin/js/confirm-close.js (modified) (6 diffs)

admin/js/confirm-close.js

@@ -4 +4 @@
 function confirmClose() {
   if (arguments.length > 0) {
-    for (var i = 0; i < arguments.length; i++) {
+    for (let i = 0; i < arguments.length; i++) {
       this.forms_id.push(arguments[i]);
     }
@@ -19 +19 @@
     // Store current form's element's values
 
-    var formsInPage = this.getForms();
-    var f, e;
-    var This = this;
+    const formsInPage = this.getForms();
+    const This = this;
     this.forms = [];
-    for (var i = 0; i < formsInPage.length; i++) {
-      f = formsInPage[i];
-      var tmpForm = [];
-      for (var j = 0; j < f.elements.length; j++) {
-        e = this.getFormElementValue(f[j]);
+    for (let i = 0; i < formsInPage.length; i++) {
+      const f = formsInPage[i];
+      let tmpForm = [];
+      for (let j = 0; j < f.elements.length; j++) {
+        const e = this.getFormElementValue(f[j]);
         if (e != undefined) {
           tmpForm.push(e);
@@ -48 +47 @@
     }
 
-    var formsInPage = this.getForms();
-    var f, e, i, j;
-    for (i = 0; i < formsInPage.length; i++) {
-      f = formsInPage[i];
+    const formsInPage = this.getForms();
+    for (let i = 0; i < formsInPage.length; i++) {
+      const f = formsInPage[i];
       var tmpForm = [];
-      for (j = 0; j < f.elements.length; j++) {
-        e = this.getFormElementValue(f[j]);
+      for (let j = 0; j < f.elements.length; j++) {
+        const e = this.getFormElementValue(f[j]);
         if (e != undefined) {
           tmpForm.push(e);
         }
       }
-      for (j = 0; j < this.forms[i].length; j++) {
+      for (let j = 0; j < this.forms[i].length; j++) {
         if (this.forms[i][j] != tmpForm[j]) {
           return false;
@@ -77 +75 @@
 
     if (this.forms_id.length > 0) {
-      var res = [];
-      var f;
-      for (var i = 0; i < this.forms_id.length; i++) {
-        f = document.getElementById(this.forms_id[i]);
+      let res = [];
+      for (let i = 0; i < this.forms_id.length; i++) {
+        const f = document.getElementById(this.forms_id[i]);
         if (f != undefined) {
           res.push(f);
@@ -134 +131 @@
 
   getFormRadioValue: function(e) {
-    for (var i = 0; i < e.length; i++) {
+    for (let i = 0; i < e.length; i++) {
       if (e[i].checked) {
         return e[i].value;
@@ -145 +142 @@
 };
 
-var confirmClosePage = new confirmClose();
+let confirmClosePage = new confirmClose();
 
 chainHandler(window, 'onload', function() {