Changeset 3583:d1b90256107c for plugins/simpleMenu

Timestamp:

09/03/17 19:50:53 (8 years ago)

Author:

Gnieark<remi@…>

Branch:

allow-target-blank-simpleMenu

Message:

fix dont overwrite title, otherwise, it's seems always being empty

File:

• plugins/simpleMenu/_public.php (modified) (4 diffs)

plugins/simpleMenu/_public.php

@@ -101 +101 @@
                     $href = html::escapeHTML($href);
 
+                    $targetBlank = ((isset($m['targetBlank'])) && ($m['targetBlank']))? true:false;
+                    
                     # Active item test
                     $active = false;
@@ -110 +112 @@
                     }
                     $title = $span = '';
+                    
                     if ($m['descr']) {
-                         if ($description == 'title' || $description == 'both') {
+                         if (($description == 'title' || $description == 'both') && $targetBlank) {
+                              $title = ' title="'.html::escapeHTML(__($m['descr'])).' ('.
+                              __("the link will open a new window").')"';
+                         }elseif($description == 'title' || $description == 'both'){
                               $title = ' title="'.html::escapeHTML(__($m['descr'])).'"';
                          }
@@ -118 +124 @@
                          }
                     }
+                    
+                    if( empty($title) && $targetBlank){
+                         $title = ' title="'.__("the link will open a new window").'"';
+                    }
+                              
                     $label = html::escapeHTML(__($m['label']));
 
@@ -139 +150 @@
                               '">'.
                               '<a href="'.$href.'"'.$item['title'].
-                              ((isset($m['targetBlank']) && ($m['targetBlank'])) ? 
-                                   'target="_blank" title="'.__("the link will open a new window").'"' 
-                                   : '').'>'.
+                              (($targetBlank) ? 'target="_blank"': '').'>'.
                               '<span class="simple-menu-label">'.$item['label'].'</span>'.
                               $item['span'].'</a>'.