Changeset 2200:0b1f90d5bb2a

Timestamp:

10/02/13 12:05:46 (12 years ago)

Author:

Nicolas <nikrou77@…>

Branch:

default

Message:

Allow checkboxesHelpers to manage checkboxes added dynamically
Add jasmine tests

Files:

• admin/js/common.js (modified) (1 diff)
• tests/functional/fixtures/entries_list.html (added)
• tests/functional/js/fix_include.js (modified) (1 diff)
• tests/functional/spec/common.js (modified) (1 diff)

admin/js/common.js

@@ -280 +280 @@
           $(e).append(document.createTextNode(' '));
 
-          target = target || $(e).parents('form').find('input[type="checkbox"]');
-          
-          var a = document.createElement('a');
-          a.href='#';
-          $(a).append(document.createTextNode(dotclear.msg.select_all));
-          a.onclick = function() {
+          $('<a href="#">'+dotclear.msg.select_all+'</a>').click(function() {
+               if (target === undefined) {
+                    target = $(e).parents('form').find('input[type="checkbox"]');
+               }
                target.check();
                return false;
-          };
-          $(e).append(a);
-
+          }).appendTo($(e));
           $(e).append(document.createTextNode(' | '));
 
-          a = document.createElement('a');
-          a.href='#';
-          $(a).append(document.createTextNode(dotclear.msg.no_selection));
-          a.onclick = function() {
+          $('<a href="#">'+dotclear.msg.no_selection+'</a>').click(function() {
+               if (target === undefined) {
+                    target = $(e).parents('form').find('input[type="checkbox"]');
+               }
                target.unCheck();
                return false;
-          };
-          $(e).append(a);
-
+          }).appendTo($(e));
           $(e).append(document.createTextNode(' - '));
 
-          a = document.createElement('a');
-          a.href='#';
-          $(a).append(document.createTextNode(dotclear.msg.invert_sel));
-          a.onclick = function() {
+          $('<a href="#">'+dotclear.msg.invert_sel+'</a>').click(function() {
+               if (target === undefined) {
+                    target = $(e).parents('form').find('input[type="checkbox"]');
+               }
                target.toggleCheck();
                return false;
-          };
-          $(e).append(a);
+          }).appendTo($(e));
      },
 

tests/functional/js/fix_include.js

@@ -20 +20 @@
 dotclear.msg.enhanced_uploader_disable = 'Temporarily disable enhanced uploader';
 
+dotclear.msg.to_select = 'Select:';
+dotclear.msg.select_all = 'select all';
+dotclear.msg.no_selection = 'no selection';
+dotclear.msg.invert_sel = 'invert selection';

tests/functional/spec/common.js

@@ -81 +81 @@
           });
      });
+
+     describe("checkboxesHelpers", function() {
+          it("Must add links to select all,none or invert selection", function() {
+               loadFixtures('entries_list.html');
+               dotclear.checkboxesHelpers($('.checkboxes-helpers', '#form-entries'));
+
+               expect($('.checkboxes-helpers a', '#form-entries').length).toBe(3);
+               expect($('.checkboxes-helpers a:eq(0)', '#form-entries').text()).toBe(dotclear.msg.select_all);
+               expect($('.checkboxes-helpers a:eq(1)', '#form-entries').text()).toBe(dotclear.msg.no_selection);
+               expect($('.checkboxes-helpers a:eq(2)', '#form-entries').text()).toBe(dotclear.msg.invert_sel);
+          });
+
+          it("Click all must select all checkboxes", function() {
+               loadFixtures('entries_list.html');
+               dotclear.checkboxesHelpers($('.checkboxes-helpers', '#form-entries'));
+               
+               $('.checkboxes-helpers a:eq(0)').click();
+               expect($('#form-entries input[name="entries[]"]:checked').length).toBe(4);
+          });
+
+          it("Click 'no selection'  must uncheck all checkboxes", function() {
+               loadFixtures('entries_list.html');
+               dotclear.checkboxesHelpers($('.checkboxes-helpers', '#form-entries'));
+
+               $('input[name="entries[]"]:eq(1)').click();
+               $('input[name="entries[]"]:eq(3)').click();
+               $('.checkboxes-helpers a:eq(1)').click();
+               expect($('#form-entries input[name="entries[]"]:checked').length).toBe(0);
+          });
+
+          it("Click invert must select all uncheck checkboxes", function() {
+               loadFixtures('entries_list.html');
+               dotclear.checkboxesHelpers($('.checkboxes-helpers', '#form-entries'));
+               
+               $('input[name="entries[]"]:eq(1)').click();
+               $('.checkboxes-helpers a:eq(2)').click();
+               expect($('#form-entries input[name="entries[]"]:checked').length).toBe(3);
+               expect($('input[name="entries[]"]:eq(0)')).toBeChecked();
+               expect($('input[name="entries[]"]:eq(1)')).not.toBeChecked();
+               expect($('input[name="entries[]"]:eq(2)')).toBeChecked();
+               expect($('input[name="entries[]"]:eq(3)')).toBeChecked();
+          });
+
+          it("Must take in consideration checkbox added dynamically", function() {
+               loadFixtures('entries_list.html');
+               dotclear.checkboxesHelpers($('.checkboxes-helpers', '#form-entries'));
+
+               $('<li><input type="checkbox" name="entries[]" value="5"/><p>title 5</p></li>').appendTo('#form-entries ul');
+
+               $('.checkboxes-helpers a:eq(0)').click();
+               expect($('#form-entries input[name="entries[]"]:checked').length).toBe(5);
+          });
+     });
 });