Changeset 1262:ec1e7bef6c1f

Timestamp:

08/03/13 15:04:24 (11 years ago)

Author:

Denis Jean-Christian <contact@…>

Branch:

2.5

Children:

1263:c4b456fb9af8, 1265:15b5a80a48a1, 1441:fb59f706335a, 1542:2de80618299a

Message:

Fix post comments number on comments deletion, fixes #1401, thanks sogos/sogox for patch and tests

File:

• inc/core/class.dc.blog.php (modified) (4 diffs)

inc/core/class.dc.blog.php

@@ -203 +203 @@
      @param    ids       <b>mixed</b>        Comment(s) ID(s)
      @param    del       <b>boolean</b>      If comment is delete, set this to true
-     */
-     public function triggerComments($ids,$del=false)
+     @param    affected_posts      <b>mixed</b>        Posts(s) ID(s)
+     */
+     public function triggerComments($ids, $del=false, $affected_posts=null)
      {
           $co_ids = dcUtils::cleanIds($ids);
+          $a_ids = dcUtils::cleanIds($affected_posts);
+          $a_tbs = array();
           
           # a) Retrieve posts affected by comments edition
-          $strReq = 
-               'SELECT post_id, comment_trackback '.
-               'FROM '.$this->prefix.'comment '.
-               'WHERE comment_id'.$this->con->in($co_ids).
-               'GROUP BY post_id,comment_trackback';
-          
-          $rs = $this->con->select($strReq);
-          
-          $a_ids = $a_tbs = array();
-          while ($rs->fetch()) {
-               $a_ids[] = (integer) $rs->post_id;
-               $a_tbs[] = (integer) $rs->comment_trackback;
+          if (empty($a_ids)) {
+               $strReq = 
+                    'SELECT post_id, comment_trackback '.
+                    'FROM '.$this->prefix.'comment '.
+                    'WHERE comment_id'.$this->con->in($co_ids).
+                    'GROUP BY post_id,comment_trackback';
+               
+               $rs = $this->con->select($strReq);
+               
+               while ($rs->fetch()) {
+                    $a_ids[] = (integer) $rs->post_id;
+                    $a_tbs[] = (integer) $rs->comment_trackback;
+               }
           }
           
@@ -255 +259 @@
           {
                $nb_comment = $nb_trackback = 0;
+               //$cur->nb_comment = $nb_comment;
                foreach($b_ids as $b_key => $b_id)
                {
@@ -2187 +2192 @@
           $co_ids = dcUtils::cleanIds($ids);
           
-          if (empty($ids)) {
+          if (empty($co_ids)) {
                throw new Exception(__('No such comment ID'));
+          }
+          
+          # Retrieve posts affected by comments edition
+          $affected_posts = array();
+          $strReq =
+               'SELECT distinct(post_id) '.
+               'FROM '.$this->prefix.'comment '.
+               'WHERE comment_id'.$this->con->in($co_ids);
+          
+          $rs = $this->con->select($strReq);
+          
+          while ($rs->fetch()) {
+               $affected_posts[] = (integer) $rs->post_id;
           }
           
@@ -2218 +2236 @@
           
           $this->con->execute($strReq);
-          $this->triggerComments($co_ids,true);
+          $this->triggerComments($co_ids, true, $affected_posts);
           $this->triggerBlog();
      }